Repository navigation
fix: distinguish urllib parsing from network access - #812
Open
sholmes222 wants to merge 1 commit into
Open
sholmes222 wants to merge 1 commit into
sholmes222 wants to merge 1 commit into
Conversation
sholmes222
force-pushed
the
fix/lp1-urllib-parse
branch
from
October 9, 2026 13:17
0ce3e8f to
fc13fe3
Compare
Keep urllib.request detection while excluding urllib.parse URL parsing from LP1 network capability findings. Signed-off-by: sholmes222 <sam.holmes@control-plane.io>
sholmes222
force-pushed
the
fix/lp1-urllib-parse
branch
from
October 9, 2026 15:46
fc13fe3 to
74a3561
Compare
Author
|
Self-review update for
CI is running for the updated head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
LP1 treated any
urllibreference as network access. That incorrectly required a network permission for local URL parsing throughurllib.parse.What changed
urllib.request, includingfrom urllib import request, as network-capable.urllib.parse, which only parses local strings.Verification