fix(supply-chain): prefer exact known-package matches in SC6 - #530
Merged
Conversation
Signed-off-by: Whj9283 <1621370123@qq.com>
Collaborator
|
On behalf of NVIDIA, thank you @agentsope for contributing to SkillSpector!
We're merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SC6 reports the known package
uvicornas a possible typosquat ofgunicornbecause the similarity loop returns before reaching the exact match. Check normalized exact membership across the popular-package set before approximate matching, preserving the existing similarity thresholds and candidate ordering for unknown packages.Add regressions through dependency analysis and the helper for overlapping known names, case folding, and underscore/hyphen normalization. Existing PyPI and npm typo-positive tests remain covered.
Addresses the uvicorn/gunicorn observation in #523, not the other findings in that issue.
Validation:
tests/unit/test_patterns_new.pypass.make lintandmake format-checkpass.PATH="$PWD/.venv/bin:$PATH" make test-unit: 4,821 passed, 14 skipped, 38 deselected, 4 expected failures..venv/bin/pytest -q -m integration tests/integration --ignore=tests/integration/test_agent_cli_live.py: 17 passed. Optional live-provider tests were not run.