docs: clarify that the installer does not require root or sudo (#406)#760
docs: clarify that the installer does not require root or sudo (#406)#760SudheerDev-AIML wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
…A#406) The install one-liner `curl ... | bash` showed a `$` prompt in the docs landing page and gave no indication of whether root was needed. Users hit permission errors and could not tell if the script was designed to run as root, via sudo, or inside Docker. - Add a "Privileges" callout to the README quickstart section explaining the installer runs as a normal user and does not need sudo. - Remove the `$ ` shell prompt prefix from the HTML terminal widget in docs/index.md to avoid implying a specific privilege level. - Add a "Privileges" section to the `install.sh --help` output. - Annotate each step in spark-install.md with whether sudo is needed. Closes NVIDIA#406 Made-with: Cursor
📝 WalkthroughWalkthroughDocumentation and installation script messages updated to clarify that the NemoClaw installer runs as a regular user without Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
77-77: Remove emoji from the callout heading.Line 77 uses
ℹ️in technical prose; please replace it with plain text (for example,**Note**or**Privileges**).As per coding guidelines, "
**/*.md: ... No emoji in technical prose."🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 77, Replace the emoji in the README heading "**ℹ️ Privileges**" with plain text to follow the documentation guideline (no emoji in technical prose); update the heading to a simple label such as "**Privileges**" or "**Note**" so the callout remains clear but contains no emoji.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@README.md`:
- Line 77: Replace the emoji in the README heading "**ℹ️ Privileges**" with
plain text to follow the documentation guideline (no emoji in technical prose);
update the heading to a simple label such as "**Privileges**" or "**Note**" so
the callout remains clear but contains no emoji.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 287641bb-6bd9-4345-970d-787e83e3c9e0
📒 Files selected for processing (4)
README.mddocs/index.mdinstall.shspark-install.md
|
Thanks, this is a great clarification. Could I suggest moving any automatic root-level pre-requisites installation stuff out of the main installer script, to a separate This way:
|
|
Thanks for submitting this PR, it clarifies the privilege requirements for the NemoClaw installer, which could improve the user experience and prevent confusion for new users. |
Summary
Clarify privilege requirements for the NemoClaw installer across all user-facing documentation.
The install one-liner
curl ... | bashshowed a$prompt in the docs landing page and gave noindication of whether root was needed, causing confusion when users hit permission errors from
prerequisite tools (Docker, OpenShell) and assumed the installer itself required elevated privileges.
Related Issue
Closes #406
Changes
normal user and does not need
sudoor root.$shell prompt prefix from the HTML terminal widget indocs/index.mdto avoidimplying a specific privilege level.
install.sh --helpoutput so the information is available atthe command line as well.
spark-install.mdwith whethersudois needed.Type of Change
Testing
npx prek run --all-filespasses (or equivalentlymake check).npm testpasses.make docsbuilds without warnings. (for doc-only changes)All hooks passed via
npx prek run --from-ref HEAD~1 --to-ref HEAD:trailing-whitespace, end-of-file-fixer, shfmt, shellcheck, SPDX headers,
markdownlint-cli2, gitleaks — all green. No code changes, so
npm testis not applicable.Checklist
General
Code Changes
N/A — doc-only PR.
Doc Changes
Summary by CodeRabbit