fix(setup-spark): clarify that onboard must be re-run after setup (fixes #738)#750
fix(setup-spark): clarify that onboard must be re-run after setup (fixes #738)#750kagura-agent wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
NVIDIA#738) After setup-spark configures Docker for cgroupns=host, users need to run 'nemoclaw onboard' again to rebuild the sandbox image. The script previously ended without any next-step guidance, leaving users unsure whether their initial onboard was sufficient. Add clear post-setup message explaining: - What to do next (run nemoclaw onboard) - Why it's needed (sandbox image must be rebuilt) - That re-running onboard is expected, not an error
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Thanks for submitting this PR, it adds post-setup guidance to clarify that onboard must be re-run, which could improve the user experience and prevent potential issues for new users. |
Summary
Add post-setup guidance to
nemoclaw setup-sparkexplaining thatnemoclaw onboardmust be re-run to rebuild the sandbox image with the updated Docker configuration.Related Issue
Fixes #738.
Changes
scripts/setup-spark.sh: Add next-step message after Docker configuration completes, explaining why re-running onboard is needed.Type of Change
Testing
bash -n scripts/setup-spark.shpasses (syntax check)Checklist
General
Summary by CodeRabbit