Add StoreOp::NONE for read-only attachments - #258
Merged
Conversation
Maps to VK_ATTACHMENT_STORE_OP_NONE (core since Vulkan 1.3) so a read-only depth attachment does not count as a store-time write; the legacy render-pass path falls back to STORE.
…dex/project-kiwi
Collaborator
|
Thanks. Adding |
dzhdanNV
added a commit
that referenced
this pull request
Sep 7, 2026
…to "STORE" if unsupported (polishing of #258)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VK_VERSION_1_3 gives us VK_ATTACHMENT_STORE_OP_NONE, this maps it from StoreOp::NONE. This allows us to avoid store-time write access for read-only attachments like depth buffers. StoreOp seems to not be in use in DX api.
AI DISCLAIMER: Fable 5.1 found this issue while working on our vulkan renderer and it seems correct to me, I had GPT-6 Astra review it for good measure.