Fix: sync ImTextureData with upstream ImGui layout - #255
Merged
dzhdanNV merged 1 commit intoAug 28, 2026
Conversation
Collaborator
|
Thanks. I will merge it today (and update all my stuff). Which ImGui version did add |
Contributor
Author
Add the missing "QueueUserData" field to ImTextureData, matching the ImGui struct introduced in ocornut/imgui@b335bf4. This keeps the interface struct in sync with the current ImGui version.
eyalezer
force-pushed
the
imgui-imTextureData-struct-fix
branch
from
August 28, 2026 06:49
a8c13d6 to
8c9abcb
Compare
Contributor
Author
|
@dzhdanNV - Done ✅ |
Collaborator
|
Thanks! Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync ImTextureData with upstream ImGui layout
This syncs the
ImTextureDatastruct inSource/Shared/ImguiInterface.hppwith the current ImGui layout (matching ocornut/imgui@b335bf4).Why this matters
The upstream ImGui
ImTextureDatastruct gained a newQueueUserDatafield:Because NRI's copy of this struct was missing that field, the two layouts drifted apart. The field ordering and offsets no longer match, which corrupts the memory layout when ImGui and NRI share this struct. This breaks using ImGui textures with NRI.
This change adds the missing
QueueUserDatafield back, restoring the correct layout.