Amoradzadeh/cp implicit filter#15199
Conversation
Signed-off-by: amoradzadeh <amoradzadeh@nvidia.com>
Signed-off-by: moradza <moradza@users.noreply.github.com>
Signed-off-by: amoradzadeh <amoradzadeh@nvidia.com>
Signed-off-by: amoradzadeh <amoradzadeh@nvidia.com>
Signed-off-by: moradza <moradza@users.noreply.github.com>
| """Compute the log poles for the implicit modal filter.""" | ||
| logp = -torch.exp(self.p.to(torch.float32)) | ||
| glogp = logp * torch.exp(self.gamma.to(torch.float32)) | ||
| if context_parallel_group is not None: |
There was a problem hiding this comment.
should this be and context_parallel_group.size() > 1:?
There was a problem hiding this comment.
I see your point, if _hyena_use_cp set to False, this can be None. Slightly confusing code, b/c it sets cp_group to None.
Signed-off-by: amoradzadeh <amoradzadeh@nvidia.com>
Co-authored-by: amoradzadeh <amoradzadeh@nvidia.com> Signed-off-by: John St John <jstjohn@nvidia.com>
Signed-off-by: amoradzadeh <amoradzadeh@nvidia.com>
Signed-off-by: moradza <moradza@users.noreply.github.com>
|
@jstjohn You can test locally CP == 1 and CP == 2 with this command. |
|
Closing this PR as "won't merge". |
Pull request was closed
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Reduce memory consumption of mixer kernels in context parallel setup.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information