Fix use-after-free in the FreeRTOS mDNS backend#30
Merged
Conversation
3100igsv
approved these changes
Jun 15, 2026
gennadiyvt
approved these changes
Jun 15, 2026
Contributor
|
Thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When an mdns search finished, the FreeRTOS backend passed its own
found_entriesvector straight to theon_entries_foundcallback. But that callback takes ownership: it processes entries and frees the vector. So the mdns backend kept using a vector that had already been freed.Fix:
Add
MdnsNotifyFoundEntries()which copies the entries into a new vector and passes that to the ship_node callback (the same approach used inship_mdns_bonjour.c)Other updates:
Remove unused include from
src/ship/mdns/ship_mdns_bonjour.cFix
FreeRTOS.hinclude insrc/common/eebus_malloc.h