Add MGCP use case support (MA & GCP)#29
Merged
Merged
Conversation
…easurement` to `EebusMeasurement`
…or` to `EebusMonitor`
…onitorContainer`
…gcp::AddFeatures()` to `/src/use_case/actor/common/eebus_monitor_features.c`
…asurement` to `MaMeasurement`
…mentDataInternal()` with `MaMeasurement::GetData()`
…vents.c` to `ma_events.c`
d-serj
reviewed
Jun 12, 2026
| return kEebusErrorOk; | ||
| } | ||
|
|
||
| EebusError AddGcpMgcp(Hpsrv* self, DeviceLocalObject* device_local, EntityLocalObject* entity_local) { |
Contributor
There was a problem hiding this comment.
Missing function declaration. Otherwise, if you do not want to create a declaration, it would be good to add a static keyword to the function definition.
| return kEebusErrorOk; | ||
| } | ||
|
|
||
| EebusError AddGridConnectionPointEntity( |
Contributor
There was a problem hiding this comment.
Missing function declaration. Otherwise, if you do not want to create a declaration, it would be good to add a 'static' keyword.
| EebusMeasurementConfigureStrategy strategy | ||
| ); | ||
|
|
||
| EebusError EebusMeasurementBaseConfigurePower( |
Contributor
There was a problem hiding this comment.
Missing functions description
…tting Co-authored-by: mihajlo-zivkovic <156680010+mihajlo-zivkovic@users.noreply.github.com>
…te functions list
…unction descriptions
d-serj
approved these changes
Jun 15, 2026
mihajlo-zivkovic
approved these changes
Jun 16, 2026
…s_measurement_base.c` update formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MGCP use case support for both MA and GCP actors (including use case implementation, CLI adjustments and examples updates).
Sponsored by Sigma Software feature