Add -Wall -Wextra -Werror compilation flags#28
Merged
Conversation
gennadiyvt
reviewed
May 28, 2026
gennadiyvt
reviewed
May 28, 2026
gennadiyvt
reviewed
May 28, 2026
gennadiyvt
reviewed
May 28, 2026
gennadiyvt
reviewed
May 28, 2026
gennadiyvt
reviewed
May 28, 2026
gennadiyvt
reviewed
May 28, 2026
gennadiyvt
reviewed
May 28, 2026
gennadiyvt
reviewed
May 28, 2026
gennadiyvt
reviewed
May 28, 2026
gennadiyvt
left a comment
Contributor
There was a problem hiding this comment.
Added some nice-to-have remarks
gennadiyvt
approved these changes
Jun 3, 2026
Contributor
|
Thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables GCC/Clang compiler warnings (
-Wall -Wextra -Werror) for both library and unit tests, and adds optional AddressSanitizer support. All warnings found by the new flags are fixed.Bugs fixed while enabling warnings:
websocket.c- return value oflws_write()was incorrectly compared against an unsigned variable so that negative error codes were not detectedeebus_data_choice.c-IsNull()andIsEmpty()were returning an error code integer through bool return typeWarning fixes:
UNUSED()macro calls for unused function parametersEebusDateToString()to use %u matching the unsigned cast (-Wformat)StringLutRecordInit()andUint64LutRecordInit()so memset is never reached with NULL pointer (-Werror=maybe-uninitialized)