Skip to content

[refs #DIG-8430] Add data-performance to Umami #394

Merged
Android63 merged 4 commits into
mainfrom
DIG-8430
Jun 25, 2026
Merged

[refs #DIG-8430] Add data-performance to Umami #394
Android63 merged 4 commits into
mainfrom
DIG-8430

Conversation

@Android63

Copy link
Copy Markdown
Contributor

Add data-performance to Umami script.

Also hide settings pages from non-sysop users.

@Android63 Android63 requested a review from a team as a code owner June 22, 2026 14:01
@Android63 Android63 requested review from Copilot and removed request for a team June 22, 2026 14:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Umami “performance” tracking support and restricts access to analytics/retention settings pages to sysop-only users via a new settings:update permission, with accompanying version/changelog updates.

Changes:

  • Add data-performance="true" to the Umami analytics script template.
  • Introduce settings:update permission and use it to gate access to Filament settings pages (Retention + Umami).
  • Bump app version to 2.0.2 and add a v2.0.2 changelog entry.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
rolesAndPermissions.json Adds new settings:update permission to the sysop role.
resources/views/vendor/umami/script.blade.php Adds Umami data-performance attribute to enable performance tracking.
config/app.php Updates app version to 2.0.2.
CHANGELOG.md Documents the v2.0.2 release changes.
app/Providers/Filament/AdminPanelProvider.php Disables Umami plugin’s built-in settings page and registers custom gated settings page.
app/Filament/Pages/RetentionSettings.php Adds access gating for the retention settings page (but currently has a boolean return-type issue).
app/Filament/Pages/ManageUmamiSettings.php Adds a custom Umami settings page with sysop-only access control.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/Filament/Pages/RetentionSettings.php
@Android63 Android63 changed the title Dig 8430 [refs #DIG-8430] Add data-performance to Umami Jun 22, 2026
@Android63 Android63 requested a review from maheshmuralip June 23, 2026 12:52
maheshmuralip
maheshmuralip previously approved these changes Jun 25, 2026
@Android63 Android63 merged commit fe68205 into main Jun 25, 2026
1 check passed
@Android63 Android63 deleted the DIG-8430 branch June 25, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants