Consolidate global_domain into domain variable#69
Merged
Conversation
mxkpp
approved these changes
May 12, 2026
Contributor
mxkpp
left a comment
mxkpp
left a comment
There was a problem hiding this comment.
Looks good and tested well
jswade-rtx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug was discovered where the ngenCERF server was not properly configuring the global_domain forcing variable, leading to the incorrect ESMF mesh file being used for oCONUS gages for NWM retrospective forcing.
After reviewing the code with Max, we decided that we could combine the global_domain and domain input variables into a single domain variable. This PR removes the global_domain variable in the Forcing section of the input.config and instead relies on the domain input for all region configuration. The global_domain CLI argument has been left unchanged.
I also updated the file name of the geo_em_PuertoRico.nc file to geo_em_Puerto_Rico.nc in s3/ngwpc-dev/rte-test-data/esmf/esmf_mesh/NWM/domain/ and s3/ngwpc-dev/kyle.larkin/esmf/esmf_mesh/NWM/domain/ to match the naming convention of the Puerto Rico domain in the msw-mgr.