Skip to content

Ngwpc 10747 lasam initial values#88

Merged
dylanlee merged 6 commits into
mainfrom
NGWPC-10747_lasam_initial_values
May 14, 2026
Merged

Ngwpc 10747 lasam initial values#88
dylanlee merged 6 commits into
mainfrom
NGWPC-10747_lasam_initial_values

Conversation

@danielcumpton
Copy link
Copy Markdown

[Short description explaining the high-level reason for the pull request]

Additions

Add code to compute initial values for LASAM parameters that are based on the soil type.

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@danielcumpton danielcumpton requested a review from dylanlee May 11, 2026 17:18
@danielcumpton danielcumpton self-assigned this May 11, 2026
danielcumpton and others added 4 commits May 12, 2026 17:04
Added LASAM soil parameter mappings to ParametersToDivideAttributesHF for HF 2.2 domain support, and fixed 500 error when calling parameter metadata without a gage_id by conditionally merging LASAM params only when gage_id is provided.
@dylanlee
Copy link
Copy Markdown

I did an additional 2 changes after testing. See commit message on last commit in PR if curious

@dylanlee dylanlee merged commit 73143ca into main May 14, 2026
1 of 3 checks passed
@dylanlee dylanlee deleted the NGWPC-10747_lasam_initial_values branch May 14, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants