Skip to content

DEV-2768: Standardize Builder & Document Props & Add Type Hints. - #347

Open
BenX00 wants to merge 1 commit into
developfrom
feat/dev-2768-standardize-builder-props
Open

DEV-2768: Standardize Builder & Document Props & Add Type Hints.#347
BenX00 wants to merge 1 commit into
developfrom
feat/dev-2768-standardize-builder-props

Conversation

@BenX00

@BenX00 BenX00 commented Jun 12, 2024

Copy link
Copy Markdown
Contributor

Changes to the builder:

  • This moves all class level properties to be either module level constants or instance level fields.
  • Adds doc strings for all constants, constructor args/instance fields, and instance level cache fields.
  • Type hints all methods in the Builder.
  • Removes dead code.
  • Removes test logic from production code.

@BenX00
BenX00 force-pushed the feat/dev-2768-standardize-builder-props branch from 9e2dfc5 to f59bd94 Compare June 13, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant