DAT-168 include fileless annotations - #115
Open
millerjs wants to merge 1 commit into
Open
Conversation
millerjs
force-pushed
the
feat/DAT-168-include-fileless-annotations
branch
5 times, most recently
from
September 30, 2016 20:30
8656dda to
8f4752d
Compare
millerjs
force-pushed
the
feat/DAT-168-include-fileless-annotations
branch
from
September 30, 2016 21:35
8f4752d to
24321d9
Compare
dankolbman
approved these changes
Sep 30, 2016
dankolbman
left a comment
dankolbman
left a comment
Contributor
There was a problem hiding this comment.
lgtm. should be checked in qa as we don't have a build box atm.
Contributor
|
Ran this in dev and the queries in the ticket both seem to agree now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses DAT-168.
The current version collects annotation documents from file documents of a case. This is why annotations with no file descendants are not collected. The fix here is to traverse the case document in full and collect any annotation documents found.
rider: remove graphviz intermediate file (test_suite_data.gv) because it's annoying
r? @dankolbman