chore: add storage pool backup metrics#3357
Closed
halfprice wants to merge 2 commits into
Closed
Conversation
The orchestrator already publishes blob_states and total_bytes_archived
on a 30s tick. Extend the same metrics query with four new aggregations
so operators can see pool activity at a glance:
storage_pools{status="live"} — pools whose end_epoch is in the future
storage_pools{status="expired"} — pools past their end_epoch (some still
within the GC retention margin, others
pending the pool-expiry sweep)
pooled_blob_refs — total junction-table size; correlates
with pending pool-cleanup work
pool_referenced_blobs — distinct blob_ids currently kept alive
by at least one pool ref
All four scan small auxiliary tables or use simple predicates, so they
add negligible cost to the existing metrics query.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
This PR is stale because it has been open 14 days with no activity. It will be closed in 7 days unless you remove the |
Contributor
|
This PR was closed because it has not seen any activity since being marked as stale. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add four operational gauges so we can see backup-side pool activity without
ad-hoc SQL:
walrus_storage_pools{status="live"|"expired"}— pool count by lifetimewalrus_pooled_blob_refs— total junction-table sizewalrus_pool_referenced_blobs— distinct blob_ids alive via poolsTest plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)