feat: Add a new endpoint for faster uploads in relay#3300
Open
sadhansood wants to merge 2 commits into
Open
Conversation
Contributor
|
Warning: This PR modifies one of the OpenAPI files. Please consider the
|
Contributor
|
This PR is stale because it has been open 14 days with no activity. It will be closed in 7 days unless you remove the |
Contributor
|
This PR is stale because it has been open 14 days with no activity. It will be closed in 7 days unless you remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a session based upload relay endpoint for lower latency uploads by accepting systematic primary slivers directly from clients. The client upload workflow using upload relay is now using this experimental endpoint is:
The relay now validates uploaded slivers against the provided blob metadata, uploads metadata and primary slivers to storage nodes with immediate intent as they arrive, derives the remaining primary and secondary slivers during completion, and then finishes the normal storage certification flow.
It also adds support for tipped relay sessions by preflighting and reserving the paid tip transaction at session creation, then verifying the reconstructed raw blob digest against the auth package before completing the upload.
Test plan
Added unit coverage for the sliver upload session flow.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)