docs: automated updates for new_feature#566
Open
jessiemongeon1 wants to merge 3 commits into
Open
Conversation
Automated update based on: Added --unsigned flag to all on-chain CLI operations (gen key and register, process all and propose, approve upgrade, reject upgrade, authorize upgrade), allowing users to bring their own wallet to sign instead of using sui cli wallet keystore
Automated update based on: Added --unsigned flag to all on-chain CLI operations (gen key and register, process all and propose, approve upgrade, reject upgrade, authorize upgrade), allowing users to bring their own wallet to sign instead of using sui cli wallet keystore
…#559 Automated update based on: Added --unsigned flag to all on-chain CLI operations (gen key and register, process all and propose, approve upgrade, reject upgrade, authorize upgrade), allowing users to bring their own wallet to sign instead of using sui cli wallet keystore
Contributor
Author
Style Guide AuditAudited 3 file(s) against the Sui Documentation Style Guide. 3 violation(s) found. All must be fixed before merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated documentation updates triggered by recent release notes.
Changes
Triggered by MystenLabs/seal#559: [cli] add option for onchain ops with --unsigned, update docs
docs/content/SealCLI.mdxdocs/content/KeyServerOps.mdxdocs/content/KeyServerCommitteeOps.mdxReview details
docs/content/SealCLI.mdxThe documentation page needs updating. The current page covers CLI commands for encryption, decryption, key generation (local demo keys), extraction, parsing, and fetching keys, but it does not document any on-chain CLI operations such as:
genkeywith on-chain registration (register)process-allandproposeapprove-upgrade,reject-upgrade,authorize-upgradeSince these on-chain operations are not documented on this page at all, the
--unsignedflag that was added to them is also not documented.What needs to be added:
A new section (e.g., after Section 7 or as a separate section) should document the on-chain CLI operations and mention the
--unsignedflag. Specifically:New section: On-chain operations — Document the on-chain CLI commands that exist:
genkey(with registration),process-all,propose,approve-upgrade,reject-upgrade, andauthorize-upgrade. Even brief descriptions of what these commands do would be valuable.--unsignedflag documentation — For each on-chain command, document the--unsignedflag, explaining that it allows users to output an unsigned transaction instead of signing with the Sui CLI wallet keystore. This enables users to bring their own wallet/signer to sign the transaction externally.For example, a paragraph or subsection like:
This is a meaningful gap — the page currently only covers local/offline operations and the
encrypt/fetch-keyscommands that interact with key servers, but none of the on-chain administrative operations are documented here.docs/content/KeyServerOps.mdxThe documentation page needs updating. The PR adds an
--unsignedflag to all on-chain CLI operations, which allows users to produce unsigned transactions and sign them with their own wallet instead of relying on the Sui CLI wallet keystore. This page contains severalsui client callcommands for on-chain operations (registering key servers, updating URLs, transferring objects) but does not mention the--unsignedflag or the possibility of using an external wallet for signing.Specific sections that need updating:
Open mode section — The
sui client callcommand for registering the key server onchain:This should mention that users can alternatively use the
--unsignedflag (or the equivalent seal-cli command with--unsigned) to produce an unsigned transaction for signing with an external wallet.Register a client section (Permissioned mode) — The
sui client callcommand for registering a client's key server object:Same update needed here.
Export and import keys section — The
sui client call --function updatecommand:And the
sui transfercommand. These should also mention the--unsignedoption.What is currently missing:
There is no mention anywhere on this page that on-chain operations can be performed without the Sui CLI keystore by using an
--unsignedflag, which outputs an unsigned transaction that can be signed by an external wallet.Suggested update:
After the first
sui client callexample in the Open mode section (or as a general note near the top of the page, perhaps after the "Network configuration" section), add a note explaining that all on-chain CLI commands support an--unsignedflag. For example:Additionally, the page references direct
sui client callcommands rather thanseal-clisubcommands for the on-chain operations. If the PR introduced dedicatedseal-clisubcommands (likeseal-cli register,seal-cli approve-upgrade, etc.) with the--unsignedflag, the page should be updated to show those commands as the primary approach, with the--unsignedvariant shown as an alternative. At minimum, the existingsui client callexamples should note that equivalentseal-clicommands exist and support--unsigned.docs/content/KeyServerCommitteeOps.mdxThe documentation page already covers the
--unsignedflag for some commands but NOT for all the commands mentioned in the PR. Let me check carefully:Commands mentioned in the PR that should have
--unsigneddocumented:genkey-and-register(gen key and register)process-all-and-propose(process all and propose)approve-upgradereject-upgradeauthorize-upgradepropose(if separate from process-all-and-propose)What the page currently documents:
genkey-and-register— ✅ Has--unsignednote in Fresh DKG member runbook step 2c AND Key rotation member runbook step 2cprocess-all-and-propose— ✅ Has--unsignednote in Fresh DKG member runbook step 4 AND Key rotation member runbook step 4approve-upgrade— ❌ No--unsignedmention (appears in the Upgrade process section, step 3)reject-upgrade— ❌ No--unsignedmention (appears in the Upgrade process section, step 3)authorize-upgrade— ❌ No--unsignedmention (appears in the Upgrade process section, step 4)Specific updates needed:
1. Upgrade process — Member step 3 (approve or reject)
In the "Upgrade member runbook" step 3, after the
approve-upgradeandreject-upgradecommands, add a note about--unsigned. Currently the section shows:and
Add after each (or as a combined note after both):
2. Upgrade process — Coordinator step 4 (authorize upgrade)
In the "Upgrade coordinator runbook" step 4, after the
authorize-upgradecommand:Add:
3.
init-rotationcommand (Key rotation coordinator runbook step 2)The PR mentions "all on-chain CLI operations." The
init-rotationcommand is an on-chain operation. Currently no--unsignednote exists for it. Similarly,publish-and-initin the Fresh DKG coordinator runbook step 2 is an on-chain operation.Add after the
init-rotationcommand block:Add after the
publish-and-initcommand block (Fresh DKG coordinator runbook step 2):Summary
The page partially covers
--unsigned(forgenkey-and-registerandprocess-all-and-propose) but is missing it forapprove-upgrade,reject-upgrade,authorize-upgrade,init-rotation, andpublish-and-init— all of which are on-chain CLI operations that should support the flag per this PR.This PR was automatically generated by the Docs Impact Monitor. Please review the changes carefully before merging.
Each file edit was generated by Claude based on the release notes and a review of the existing documentation content.