validate commit sha when tagging#530
Open
quepcompute wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix release workflow tagging commits that aren't on the
mainbranch. Run #28 tagged8653882— an orphaned PR branch commit from a squash merge — producing a release pointing at a SHA unreachable frommain.Three changes:
if: github.ref == 'refs/heads/main'prevents the release job from running whenworkflow_dispatchis triggered from a feature branch.github.shafallback: Replacesref: 'main'(resolves at checkout time, race-prone) withgithub.sha(fixed at trigger time).mainvia the compare API — modeled aftersui-operations/.github/actions/validate-commit.Test Plan
workflow_dispatchfrommainwith nocommit_sha— should resolve to currentmainHEAD and pass validationworkflow_dispatchwith an explicit SHA from a merged-and-squashed PR branch — should fail at "not an ancestor of main"Cargo.tomlversion bump tomain— should auto-tag the correct squash-merge commit