predict: move bench service to deepbook-services#1051
Merged
Conversation
The bench API service is pure ops infrastructure with no dependency on the Move code or simulation TypeScript. It now lives in deepbook-services alongside the other deepbook-* services. See: MystenLabs/deepbook-services#7 The companion predict-sim image stays here because its entrypoint clones packages/predict/simulations/ at the requested SHA — they are tightly coupled to the protocol code by design. The sim.ts change to read SCENARIO_PATH from env (needed to point the sim at the GCS-downloaded scenario CSV) is deferred to a separate PR from another teammate who owns that area. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5956715 to
c49f7d2
Compare
emmazzz
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/bench/anddocker/predict-bench/— the bench service moves to deepbook-services alongside the other deepbook-* servicescrates/benchfrom the workspaceCargo.toml;Cargo.lockregenerated without bench's transitive depsdocker/predict-sim/andpackages/predict/simulations/here — the sim container's entrypoint clonespackages/predict/simulations/at the requested SHA per benchmark run, so they are tightly coupled to the protocol code by designKey decisions
predict-bench.ymlworkflow stays here — it only references the deployed bench service by URL, no local pathssim.tsis unchanged in this PR. TheloadScenario(process.env.SCENARIO_PATH)change needed to let the sim pick up the GCS-downloaded scenario CSV is being handled in a separate PR by another teammate who owns that area. Until that lands, benchmarks against this PR's commits will silently ignore the bucket CSV and use the in-reposcenario_mar6_1000mints.csv, which matches the pre-bench-move behavior — so this PR is fully backwards-compatible and safe to land independentlyCoordination
Part of a coordinated move across three repos:
Recommended landing order: deepbook-services first → sui-operations second → this PR last (avoids any broken-deploy window — the bench code exists in both repos briefly, sui-operations switches sources, then this PR cleans up). The companion sim.ts change is decoupled and will land on its own schedule.
Test plan
cargo checkclean on the workspace after removal🤖 Generated with Claude Code