closes issue #25, polish mobile layout#33
Merged
Conversation
Contributor
Author
|
kindly merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes issue #25 ,Implement mobile bottom navigation bar for dashboard routes
The app had no shared navigation shell — all dashboard pages were isolated with no way to move between routes on mobile.
Added a fixed bottom navigation bar (BottomNav.tsx) with four tabs: Discover, Dashboard, Subscriptions, and Profile. The active tab highlights in rose/pink with a filled icon; inactive tabs show outline icons in grey. Each tap target meets the 44px minimum and the bar accounts for the iOS home indicator via env(safe-area-inset-bottom). On desktop (768px and above) the bar hides itself, ready to hand off to a future sidebar.
Created the missing (dashboard)/layout.tsx shell that wraps all dashboard pages with the nav and applies bottom padding to prevent content from being obscured by the fixed bar.
Added placeholder pages for /discover and /subscriptions — the two routes referenced by the nav that did not previously exist — and extended the auth middleware to protect them the same way as /dashboard and /profile.