chore: update targetSdk to 36, dynamic Java version, fix exported attrs and warnings - #193
Closed
codeiva4u wants to merge 18 commits into
Closed
chore: update targetSdk to 36, dynamic Java version, fix exported attrs and warnings#193codeiva4u wants to merge 18 commits into
codeiva4u wants to merge 18 commits into
Conversation
…rs and warnings - targetSdkVersion: 29 -> 36 (Android 16, latest) - Java version centralized in root build.gradle via ext.javaVersion - Auto-detects installed JVM, caps at Java 21 - All 23 submodules now reference rootProject.ext.javaVersion - GitHub Actions: java-version updated to 21 in all 4 workflows - AndroidManifest: added missing android:exported to 17 components required for targetSdk >= 31 (Android 12+) - Cast module AndroidManifest: fixed exported attributes - Suppressed pre-existing deprecated API warnings: - launchWhenStarted/launchWhenResumed -> @Suppress - getParcelable/getParcelableExtra/getSerializableExtra -> @Suppress - startActivityForResult -> @Suppress - onBackPressed override -> @Suppress OVERRIDE_DEPRECATION - NetworkInfo -> @file:Suppress in GcmPrefs - ExperimentalCoroutinesApi -> @file:OptIn in Tasks.kt - Handler() -> Handler(Looper.getMainLooper()) fixed - play-services-core-proto: jvmTarget made dynamic
|
There's a lot of unneeded changes here. Is the only required change to increment the Android SDK? We should use upstream values: https://github.com/microg/GmsCore/blob/9a206ae115d6f4d99300def2aea447332ac84260/build.gradle#L43-L44 |
- Suppressed GestureBackNavigation in MainActivity - Added FLAG_IMMUTABLE to PendingIntent in GcmNetworkManager
…UTABLE for Android 12+/14+ lint compliance
…e context.startService directly
…eases in workflow
…ion and secret fallbacks
…1, v2, v3 schemes) and zipalign
|
Your ai code bot is going off the rails and changing completely unrelated code for no good reason. |
…lve Play Protect malware flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Note: All warning fixes are safe annotations or explicit loopers that do not change runtime behavior.