-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: cap WaitFor at 90s and let new input end the wait #4061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ea1293c
2289e1e
767f98a
5ceb8c5
f84192e
750501c
b0fded2
65b25e6
1f40d5e
517ba3b
242e5a7
3f68738
b37c1ee
4840cc0
f20d480
31a5e68
7d19195
1c4783f
925f669
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": minor | ||
| --- | ||
|
|
||
| Cap the agent's in-turn wait for background tasks at 90 seconds (longer timeouts are no longer accepted), discourage repeated waits, and let a new message end the wait immediately. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -122,6 +122,7 @@ export interface SessionEventHost { | |
| updateTerminalTitle(): void; | ||
| sendQueuedMessage(session: Session, item: QueuedMessage): void; | ||
| shiftQueuedMessage(): QueuedMessage | undefined; | ||
| steerQueuedMessagesIntoRunningTurn(): void; | ||
| handleTurnStarted?(event: TurnStartedEvent): void; | ||
| handleTurnEnded?(event: TurnEndedEvent): void; | ||
| readonly btwPanelController: BtwPanelController; | ||
|
|
@@ -670,6 +671,11 @@ export class SessionEventHandler { | |
| } | ||
|
|
||
| private handleToolProgress(event: ToolProgressEvent): void { | ||
| // Input queued before the wait began would otherwise sit until the wait | ||
| // returns; steering it now ends the wait so the model reads it first. | ||
| if (this.host.streamingUI.markWaitForRunning(event.toolCallId)) { | ||
| this.host.steerQueuedMessagesIntoRunningTurn(); | ||
|
chengluyu marked this conversation as resolved.
Comment on lines
+676
to
+677
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
If a genuinely blocking AGENTS.md reference: AGENTS.md:L98-L100 Useful? React with 👍 / 👎. |
||
| } | ||
| const text = event.update.text; | ||
| if (text === undefined || text.length === 0) return; | ||
| const tc = this.host.streamingUI.getToolComponent(event.toolCallId); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.