Skip to content

feat: turn off filesystem watch by default - #3931

Merged
liruifengv merged 2 commits into
MoonshotAI:mainfrom
sailist:feat-256-09-19-watch-default-off
Sep 19, 2026
Merged

liruifengv merged 2 commits into
MoonshotAI:mainfrom
sailist:feat-256-09-19-watch-default-off

Conversation

@sailist

@sailist sailist commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Related Issue

No linked issue — internal change.

Problem

Filesystem watchers that hot-reload local.toml, AGENTS.md, skills, MCP config, and config.toml are on by default. On some environments (notably Windows with deep home/project directories) the recursive watching adds constant event pressure, so the default should be off; users who want hot reload can opt in explicitly.

What changed

  • The [watch] enabled / KIMI_CODE_WATCH switch now defaults to off: with no config and no env var, the process attaches no filesystem watchers and file changes are picked up only after restart. KIMI_CODE_WATCH=1 or [watch] enabled = true explicitly turns watching back on; the env var keeps its higher priority over the config file.
  • Tests that relied on the previous default-on behavior now enable watching explicitly (no test count change).
  • User docs (config-files, env-vars, both locales) updated to describe the new default.

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked a related issue (external PRs: the issue must have a maintainer's /approve).
  • I have added tests that prove my feature works.
  • Ran gen-changesets skill, or this PR needs no changeset.
  • Ran gen-docs skill, or this PR needs no doc update.

@changeset-bot

changeset-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d317897

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@moonshot-ai/kimi-code Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 19, 2026

Copy link
Copy Markdown
pnpm dlx https://pkg.pr.new/@moonshot-ai/kimi-code@d317897
npx https://pkg.pr.new/@moonshot-ai/kimi-code@d317897

commit: d317897

@liruifengv liruifengv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liruifengv
liruifengv merged commit f17a22e into MoonshotAI:main Sep 19, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants