Skip to content

fix(agent-core-v2): deliver cron-fired prompts as single opening turn message #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sailist wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(agent-core-v2): deliver cron-fired prompts as single opening turn message #3723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ad9786
fix(agent-core-v2): deliver cron-fired prompts as single opening turn…
sailist Sep 11, 2026
4a56871
test(agent-core-v2): drop stale compaction controller test for remove…
sailist Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/agent-core-v2/src/agent/loop/turnEvents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export function turnPromptAttachments(

export function isDisplayablePromptOrigin(origin: PromptOrigin): boolean {
if (origin.kind === 'user') return true;
if (origin.kind === 'cron_job' || origin.kind === 'cron_missed') return true;

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add a CLI changeset for the transcript fix

This change fixes a user-visible duplicate message in the CLI session transcript, but the commit adds no changeset. Without an @moonshot-ai/kimi-code patch changeset, the fix will ship without the required user-facing changelog entry; add the short changeset mandated for perceptible behavior changes.

AGENTS.md reference: AGENTS.md:L85-L86

Useful? React with 👍 / 👎.

if (origin.kind === 'system_trigger' && origin.name === 'subagent') return true;
return (
(origin.kind === 'skill_activation' || origin.kind === 'plugin_command') &&
Expand Down
11 changes: 8 additions & 3 deletions packages/agent-core-v2/src/agent/prompt/promptService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ export class AgentPromptService implements IAgentPromptService {
id: ownerPromptId,
content: gateImageFormatParts(rerouted.content, this.profile.getModelProviderType()),
};
const request = {
const steered = this.loop.steer({
message: gated,
promptId: ownerPromptId,
onMaterialize: () => {
Expand All @@ -505,8 +505,13 @@ export class AgentPromptService implements IAgentPromptService {
);
this.notifyCaptions(captions, ownerPromptId);
},
};
return this.loop.steer(request) ?? this.loop.submit(request).turn;
});
if (steered !== undefined) return steered;
return this.loop.submit({
message: gated,
promptId: ownerPromptId,
onMaterialize: () => this.notifyCaptions(captions, ownerPromptId),
}).turn;
}

async retry(): Promise<Turn | undefined> {
Expand Down
Loading
Loading