Repository navigation
feat(agent-v2): split tower mode tips - #3386
Closed
tpoisonooo wants to merge 4 commits into
Closed
tpoisonooo wants to merge 4 commits into
tpoisonooo wants to merge 4 commits into
Conversation
added 2 commits
August 31, 2026 13:36
The enable failure message no longer lumps both causes together: when the tower experiment is disabled it now says how to enable it (KIMI_CODE_EXPERIMENTAL_TOWER=1 and a restart), and when another live session owns the workspace tower it says so. Adds IAgentTowerService.isAvailable so the SDK and kap-server call sites can tell the two apart, and stubs KIMI_CODE_EXPERIMENTAL_TOWER off in the unavailable-case test so it no longer depends on the outer env.
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae4216507a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…iagnostic AgentTowerService.enter() is a silent no-op for non-main agents and isAvailable includes the main-agent check, so a setTowerMode(true) addressed at a child interactive agent fell into the disabled-experiment branch and told callers to enable the flag and restart — which cannot fix the failure. Throw a dedicated main-agent diagnostic before the disabled/owned cause split.
🦋 Changeset detectedLatest commit: 8ad3b0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The note was appended to tower-mode-improvements.md, which already exists on main from MoonshotAI#3346; changeset status only counts files a PR adds, so the PR reported no changeset. Restore the merged entry and carry the note as a new changeset instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #(issue_number)
Problem
区分 2 种 tower mode 错误提醒：
What changed
Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.