Skip to content

feat(i18n): add Spanish medical knowledge locale - #104

Closed
Davidson3556 wants to merge 3 commits into
MoleCare:mainfrom
Davidson3556:issue-22-spanish-translation
Closed

Davidson3556 wants to merge 3 commits into
MoleCare:mainfrom
Davidson3556:issue-22-spanish-translation

Conversation

@Davidson3556

Copy link
Copy Markdown
Contributor

Important

This is a stacked draft that depends on #103. Until #103 merges, GitHub will show the scaffold commits in this diff as well.

What does this change?

Adds a complete Spanish locale for the current educational dermatology knowledge surface:

  • All 10 knowledge-base entries and their search keywords
  • All four knowledge resources, including list metadata and full payload copy
  • All three canonical clinical-safety disclaimers
  • Accentless and compact search aliases such as asimetria, diametro, 6mm, evolucion, cancer de piel, and proteccion solar
  • Focused tests for explicit loading, accented/unaccented search, localized resources, tool output, and disclaimer invariants

The translation covers current main. It intentionally excludes the four resources from closed PR #91 because those resources still await clinician approval and have not shipped.

Translation and review status

This translation is machine-assisted. It is not represented as native-speaker or professional translation.

Terminology was cross-checked against:

Before this can merge, it needs:

  • Native Spanish review of all user-facing copy
  • Maintainer review
  • Explicit clinical-safety approval of every translated disclaimer

Related issue

Depends on #103
Fixes #22 after the reviews above are complete

Checklist

  • npm run build passes
  • No tools were added or removed
  • No new tool input schemas
  • Works in mock mode
  • No secrets, real hostnames, account IDs, or personal data added
  • No patient images added, including in tests
  • Disclaimer translations preserve “educational only” and “not medical advice” meaning
  • Full test suite passes: 119/119
  • npm pack --dry-run includes locales/es/medical-kb.json

Does this change a tool's response shape?

No. This adds a locale asset and tests. English remains the runtime default; client-facing locale negotiation is tracked separately in #21.

This translation is machine-assisted and requires native-speaker, maintainer, and clinical-safety review before merge.
@YauhenBichel

Copy link
Copy Markdown
Member

Thank you for this, and I am sorry to be closing it — the work is not the problem.

MoleCare is a health product without clinical sign-off, so we hold a firm line: molecare-mcp never makes a clinical decision, and we do not ship medical wording that nobody here can vouch for. English text we already have has been through that thinking. A Spanish version needs someone who can read it as a clinician, in Spanish, and say it is right. We do not have that person today, and merging without them would quietly make the app a source of medical wording in a language we cannot check.

That is a limit on us, not on your work. The translation looks thorough, and the search aliases (asimetria, diametro, evolucion) show you thought about how people actually type.

Your branch stays where it is — nothing is deleted, and if a clinician joins who can review Spanish, this is the obvious place to start.

#103 is a different story: it moves the English text without changing a byte of it, so it needs no clinical review. I have reviewed it and I am happy with it.

Really, thank you for the care you put into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n: Community translations for medical KB (per-language PRs welcome)

2 participants