Conversation
- Public profile: hero layout (name above, photo beside bio), wider column, dev sample bio on Add bio - Mock identity: localStorage handle/avatar/bio, shell signed-in gate, wallet vs SSO kind - Organizations route; registration mock replaced; sign-in required screens - Wallet sessions: Modulr.Assets asset protection CTA (assets.modulr.cloud) - Theme/settings tweaks for shell panels Made-with: Cursor
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, push a new commit or reopen this pull request to trigger a review.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab04ce4999
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <p className="modulr-text-muted mt-4 text-sm leading-relaxed">{description}</p> | ||
| <div className="mt-8 flex flex-col gap-3 sm:flex-row sm:flex-wrap"> | ||
| <Link | ||
| to="/#shell-sign-in" |
There was a problem hiding this comment.
Use real hash scrolling for sign-in deep links
Link to="/#shell-sign-in" relies on native anchor behavior, but these links are handled by React Router navigation and this repo has no location.hash scroll handler, so users coming from locked screens can be routed to / without being moved to the sign-in panel. In practice, the “Go to sign-in” CTA may land at the top of the home page instead of the #shell-sign-in section, adding friction to the primary recovery path.
Useful? React with 👍 / 👎.
- WelcomeHome: scroll #shell-sign-in into view after React Router navigation (rAF + smooth scroll) - Shared routeToShellSignInSection for Link targets (header, sign-in gate, home CTA) - CI: retry npm ci up to 3 times with backoff to mitigate ECONNRESET from registry Made-with: Cursor
Public profile: hero layout (name above, photo beside bio), wider column, dev sample bio on Add bio
Mock identity: localStorage handle/avatar/bio, shell signed-in gate, wallet vs SSO kind
Organizations route; registration mock replaced; sign-in required screens
Wallet sessions: Modulr.Assets asset protection CTA (assets.modulr.cloud)
Theme/settings tweaks for shell panels