Skip to content

Added profile page, mock credits and fixed org check#61

Merged
Undline merged 2 commits into
mainfrom
dev
Apr 14, 2026
Merged

Added profile page, mock credits and fixed org check#61
Undline merged 2 commits into
mainfrom
dev

Conversation

@Undline
Copy link
Copy Markdown
Contributor

@Undline Undline commented Apr 14, 2026

No description provided.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, push a new commit or reopen this pull request to trigger a review.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6111e12562

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +109 to +112
return validate_modulr_core_registry_apex_name(
name,
field_label="organization_name",
invalid_code=ErrorCode.INVALID_NAME,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep org registration and resolve_name validation consistent

Delegating validate_modulr_org_domain to validate_modulr_core_registry_apex_name now allows single-label orgs (e.g. acme) in register_org, but handle_resolve_name still validates with validate_modulr_resolve_name, which requires domain.subdomain format. This creates a regression where a successfully registered org name cannot be resolved forward (resolve_name rejects it before lookup), breaking the advertised register_orgresolve_name flow for newly accepted names.

Useful? React with 👍 / 👎.

@Undline Undline merged commit 0a9d60e into main Apr 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant