[Feat] Asu: integrate submit flow with transport runtime #999
Merged
Infinite666 merged 4 commits intoJun 6, 2026
Conversation
yuanzhg078
requested review from
FangRun2,
Infinite666,
Tarrei,
Wwwzff,
mag1c-h,
nrj868 and
ygwpz
as code owners
Fengli5355
reviewed
Jun 5, 2026
Fengli5355
reviewed
Jun 5, 2026
Infinite666
reviewed
Jun 5, 2026
yuanzhg078
force-pushed
the
dev_asu_trans_pr_3
branch
from
b87238a to
fe013a6
Compare
Infinite666
reviewed
Jun 6, 2026
ygwpz
reviewed
Jun 6, 2026
yuanzhg078
force-pushed
the
dev_asu_trans_pr_3
branch
from
50555f9 to
55695b1
Compare
Wwwzff
reviewed
Jun 6, 2026
yuanzhg078
force-pushed
the
dev_asu_trans_pr_3
branch
from
55695b1 to
3b41646
Compare
Wwwzff
reviewed
Jun 6, 2026
yuanzhg078
force-pushed
the
dev_asu_trans_pr_3
branch
3 times, most recently
from
fc14996 to
80b3e15
Compare
Initialize request buffers and protocol state in AsuTransportImpl, then drive sub-batch send and completion polling through the worker threads. Parse transport.* config attrs so SQE and send parameters flow from client config into transport initialization.
… Address some review comments.
…nfig parser. Merge common part of ClientConfigParser and TransportConfigParser into common/. # Conflicts: # ucm/transport/kv/asu/trans/src/asu_transport_impl.cpp
yuanzhg078
force-pushed
the
dev_asu_trans_pr_3
branch
from
80b3e15 to
f1a8bbf
Compare
Infinite666
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Integrate the ASU submit flow into AsuTransportImpl so async transport APIs can build SQEs, send sub-batches, poll completions, and return final task/query results.
Modifications
Initialize send buffer manager, flag buffer manager, and ProtocolManager during transport initialization.
Validate SQE/send attrs before starting transport worker threads.
Add request CID allocation for ASU SQE submissions.
Add completion polling thread to detect completed response CIDs, unpack CQEs, map response status, and finalize sub-batches.
Replace placeholder CompleteTask logic with real request submission, connection assignment, send-buffer construction, send execution, cancellation cleanup, and completion finalization.
Treat vector LoadAsync and StoreAsync as BATCH_LOAD and BATCH_STORE so they use ASU batch SQE flow.
Build TaskResult entryStatus from completed sub-batches and derive QueryResult from ASU query entry status.
Parse transport.* config attrs and propagate them into each TransportConfig for SQE/send configuration.
Test
Runtime integration was not fully executed locally because ASU transport execution depends on the Ascend/ACL runtime environment. Covered paths are validated through ASU transport unit tests for request submission, send-buffer construction, completion handling, response status mapping, and config attr parsing.