[Feat] Asu: add transport sub-batch foundation#997
Open
yuanzhg078 wants to merge 1 commit into
Open
Conversation
Introduce ASU sub-batch task state, IO scheduling limits, response status mapping, and completion finalization primitives. Add focused tests for scheduler splitting, CQE/result status conversion, buffer release, and terminal task state handling.
yuanzhg078
requested review from
FangRun2,
Tarrei,
Wwwzff,
mag1c-h,
nrj868 and
ygwpz
as code owners
pyxyzc
reviewed
Jun 5, 2026
| set(Ascend_ROOT "/usr/local/Ascend/ascend-toolkit/latest" CACHE PATH "Path to Ascend root directory") | ||
| endif() | ||
|
|
||
| find_path(ASU_ASCEND_INCLUDE_DIR |
Contributor
There was a problem hiding this comment.
Require acl/acl.h before checking the runtime. Move the Ascend header discovery inside the Ascend runtime block, or make the option explicitly reject non-Ascend runtimes.
pyxyzc
reviewed
Jun 5, 2026
pyxyzc
reviewed
Jun 5, 2026
Infinite666
reviewed
Jun 5, 2026
| } // namespace | ||
|
|
||
| std::vector<IoScheduler::ScheduledIoBatch> IoScheduler::SplitForAsu( | ||
| const BatchView<KVBuffer>& entries, std::size_t maxIoNum) const |
Contributor
There was a problem hiding this comment.
Can we set maxIoNum when IoScheduler init like config instead of passing it every time?
Infinite666
reviewed
Jun 5, 2026
Infinite666
reviewed
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add the ASU transport sub-batch foundation for splitting large requests, tracking sub-batch state, mapping ASU response/result codes, and finalizing transport task completion.
Modifications
Add TransportSubBatchContext and TransportSubBatchState to track per-sub-batch CID, operation type, connection, buffers, status, and entry results.
Add ASU batch limits by operation type
Add IoScheduler to split entry and key batches into SSU-compliant sub-batches.
Add ASU response status mapping from CQE status and result-buffer entries to transport Status and QueryResult.
Add task completion utilities to release send/flag buffers, release connection inflight counts, count terminal sub-batches, and finalize task state.
Update BufferManager SGE lkey assignment and related test expectation.
Wire ASU transport unit tests into the CMake test target.
Test
Added AsuResponseStatusTest, IoSchedulerTest, TransportTaskCompletionTest, and updated BufferManagerTest coverage