[Feat]Wa dump blockwise#992
Open
wuhuxiao wants to merge 2 commits into
Open
Conversation
ygwpz
reviewed
Jun 3, 2026
ygwpz
reviewed
Jun 3, 2026
ygwpz
reviewed
Jun 4, 2026
| self._role != KVConnectorRole.WORKER and dp_rank == 0 | ||
| ) | ||
| if config.get("posix_capacity_gb", None) is not None: | ||
| config["posix_capacity_gb"] = int(config["posix_capacity_gb"]) // 2 |
Contributor
There was a problem hiding this comment.
💡 Suggestion: This division of posix_capacity_gb by 2 needs documentation. Why is the capacity halved? Is it to split capacity between FA and WA stores? Consider adding a comment explaining the rationale to avoid confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add configurable block-wise WA KV cache dumping for the FAWA connector.
Previously, WA cache dumping only persisted the final WA tail block for each chunk prefill. This made WA external-cache reuse depend on chunk boundaries and could miss intermediate canonical block boundaries. This PR adds an option to dump WA cache block-wise so each canonical hash block can persist its corresponding WA tail state.
Modifications
wa_dump_block_wiseconfig option, defaulting totrue.posix_capacity_gbbetween FA and WA stores.wa_dump_block_wiseinexamples/ucm_config_example.yaml.Test