[feat] hma connector supports GPU buffer MR for GPUDirct RDMA#981
Open
relat-ivity wants to merge 8 commits into
Open
[feat] hma connector supports GPU buffer MR for GPUDirct RDMA#981relat-ivity wants to merge 8 commits into
relat-ivity wants to merge 8 commits into
Conversation
ygwpz
reviewed
May 29, 2026
ygwpz
reviewed
May 29, 2026
ygwpz
reviewed
May 29, 2026
ygwpz
reviewed
May 29, 2026
ygwpz
reviewed
May 29, 2026
ygwpz
reviewed
Jun 4, 2026
ygwpz
reviewed
Jun 4, 2026
ygwpz
reviewed
Jun 13, 2026
ygwpz
left a comment
Contributor
There was a problem hiding this comment.
Follow-up Review - PR #981
Previous Concerns: All Addressed ✅
All 7 concerns from the previous review have been successfully addressed:
- ✅ Data integrity assertion (Line 167-169): Added
assert len(buffer_addrs) == len(buffer_sizes) - ✅ Code clarity (Line 29-30): Added comment explaining GPU buffer purpose
- ✅ Debug logging (Line 119-125): Added logging for GPU buffer registration
- ✅ Redundant int() conversion (Line 171): Simplified key creation
- ✅ Type safety (Line 112-116): Added validation for non-empty lists
- ✅ Overflow protection (Line 46): Changed to safe sum calculation
- ✅ Warning for missing layouts (Line 159-163): Added logging instead of silent skip
New Observations (Minor - L3-L5)
Three minor suggestions for code quality improvements. See inline comments below.
Summary
The new commits thoroughly address all previous concerns with appropriate safeguards, logging, and validation. The implementation is now more robust and maintainable. Good work!
The three minor suggestions below are optional improvements that could be addressed in a follow-up PR if desired.
ygwpz
reviewed
Jun 13, 2026
ygwpz
reviewed
Jun 13, 2026
ygwpz
reviewed
Jun 13, 2026
ygwpz
reviewed
Jun 16, 2026
ygwpz
reviewed
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Enable the HMA connector to provide GPU KV buffer address and size metadata to UCM stores, following the existing ucm_connector registration logic in PR #958.
Modifications
hma_connector.py: Collects GPU buffer addresses and sizes of the vLLM KV cache, and passes them to UCM store for GDR pre-registration.Test