icon rendering/fetching#53
Draft
Marbowls wants to merge 11 commits into
Draft
Conversation
it uses linicon-theme to get current them and freedesktop-icons find the file location
…er using freedesktop-icons and ratatui-image
Collaborator
Author
|
should add https://www.arewesixelyet.com/ so people can check what is sixel supported or not |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
icon.rs finds the icon path and theme, strips absolute path from dekstop file.
graphics.rs does the ratattui-image protocol stuffstuff
run.rs find unchached icons spawn a bg process and sends it to the state machine
app_ui.rs renders based on need draw instead of fps
ps
(you migt want to add redb icon maping in the future so that it doesnt have to search for the icons everytime and it could also remeber theme name so the theme can switch seamlessly and also adding config options but not my job.)
Summary by cubic
Add theme‑aware icon lookup and on‑demand rendering to the app launcher. Icons now show next to app names with async loading, caching, and fewer redraws.
New Features
linicon-theme+freedesktop-icons(absolute paths supported;hicolorfallback).ratatui-image; PNG and SVG supported (SVG rasterized viausvg/resvg/tiny-skia).halfblocksfallback when graphics aren’t supported.Performance
Written for commit 0de2edd. Summary will update on new commits.