Feat/sdk vue adapter#273
Conversation
|
@Aboyeji-Isaac is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Aboyeji-Isaac Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Miracle656
left a comment
There was a problem hiding this comment.
Thanks for the Vue adapter — a framework-agnostic adapter is genuinely wanted, and the sdk/vue/ package + example app look well-structured.
The blocker is sdk/src/core/InvisibleWalletCore.ts — this PR introduces an 882-line parallel reimplementation of the wallet core, including the WebAuthn signAuthEntry / sigVec assembly that feeds the contract's __check_auth. That signing path has six non-obvious correctness requirements (custom-account host-fn invocation, low-S normalization, signature expiration, footprint via re-simulation, sequence handling, and exact sigVec length), and a second implementation that can silently drift from the canonical one in useInvisibleWallet.ts is a real security/maintenance risk.
Could you restructure so the Vue adapter consumes the existing core logic rather than duplicating it? If a framework-agnostic core extraction is the goal, that's a worthwhile change but it should be its own focused PR (factoring useInvisibleWallet into a shared core that both React and Vue import — not a fork of it), so the signing path stays single-sourced and can get a dedicated security review. Happy to review that core-extraction PR separately. Moving this one to changes-requested in the meantime.
Closes #173
sdk/src/core/InvisibleWalletCore.tssdk/vue/—@veil/invisible-wallet-vuepackage withuseInvisibleWalletVue 3 composablesdk/src/examples/vue/(register, login, deploy, send)sdk/vue/dist/is gitignored — build output is not committed