Feat/i18n#212
Open
Harbduls wants to merge 2 commits into
Open
Conversation
- Install react-i18next, i18next, and i18next-browser-languagedetector - Create i18n configuration with lazy-loading from /locales - Add English baseline translations for all user-facing strings - Add Spanish translations for dashboard, send, receive, and settings flows - Wrap user-facing strings in t() calls across key pages - Add LanguageSwitcher component in settings page - Auto-detect browser language on first load - Persist language selection in localStorage - Organize translations into logical namespaces: common, dashboard, send, receive, settings, errors
|
@Harbduls is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Harbduls Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Miracle656
requested changes
Jun 3, 2026
Owner
Miracle656
left a comment
Miracle656
left a comment
There was a problem hiding this comment.
Nice work on i18n — the en/es locale split, LanguageSwitcher, and lib/i18n.ts are well-organized. A few things before merge:
- Conflicts — the branch is behind
mainand now conflicts (severalapp/*/page.tsxfiles have moved, pluspackage-lock.json). Please rebase on the latestmain. - Remove committed build artifacts —
frontend/wallet/tsconfig.tsbuildinfoand.vscode/settings.jsonshouldn't be in the PR (the tsbuildinfo is a generated cache). Please drop them and add tsbuildinfo to.gitignoreif it isn't already.
Once rebased and the artifacts are removed, I'll review the locale wiring and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #170