Repository navigation
ci: pin Rust 1.90 in the docker builds and commit Cargo.lock - #1
Merged
Merged
Conversation
The napi-rs builder images ship rustc 1.82 (debian) / 1.83 (alpine). Without a lockfile cargo resolves the newest crates, which now need rustc 1.88+ (napi-build 2.6.0), so both linux builds fail. Updating the image's own stable toolchain fails on overlayfs, so install a pinned 1.90.0 next to it. Commit Cargo.lock so builds stop drifting. Also test the bindings on Node 22 and 24 instead of the EOL 18 and 20. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Yarn 1 enforces engines, and ava 6.1.3 only allows Node <= 22. The runners' preinstalled Node (used by the docker build jobs) and the new Node 24 test jobs both failed at yarn install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
InventivetalentDev
marked this pull request as ready for review
October 22, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the CI build so binaries can publish again.
x86_64-unknown-linux-gnuandx86_64-unknown-linux-musljobs install Rust 1.90.0 inside the napi-rs builder image and build with it (RUSTUP_TOOLCHAIN=1.90.0).Cargo.lock: now committed, and removed from.gitignore, so dependency versions stop drifting between builds.ava:^6.0.1→^6.4.1(lockfile resolved 6.1.3 before), the first 6.x release whoseenginesallows Node 24.Why
CI has failed since April, so 1.0.6 never published. Three separate problems:
nodejs-rust:lts-debian/lts-alpinebuilder images ship rustc 1.82 / 1.83. With no lockfile, cargo resolves the newest crates, andnapi-build2.6.0 now needs rustc 1.88.rustup update stableinside those images fails with a cross-device rename error, so the fix installs a separately versioned toolchain next to the old one.yarn installon the runner's preinstalled Node, now 24. Yarn 1 enforcesengines, andava6.1.3 only allows Node up to 22.Risk
Low. Only CI and dev dependencies change; the crate source is unchanged. If 1.90.0 can't build a future dependency bump, the Linux jobs fail at build time, before anything publishes.
Testing
Not a release, skipping publish.x86_64-unknown-linux-muslinnodejs-rust:lts-alpinewith Rust 1.90.0, then ranyarn test(ava 6.4.1) onnode:24-alpine: 13 tests pass. CI has no musl test job, so this is the only check of the musl binary.Note
AI-assisted.