Skip to content

fix: inject llm config into class in local executor #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
e06084 merged 1 commit into from
May 18, 2026
Merged

fix: inject llm config into class in local executor #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dingo/config/input_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ class ExecutorArgs(BaseModel):


class EvaluatorRuleArgs(BaseModel):
model_config = {"extra": "forbid"}

threshold: Optional[float] = None
pattern: Optional[str] = None
key_list: Optional[List[str]] = None
Expand Down Expand Up @@ -119,7 +121,7 @@ class EvaluatorLLMArgs(BaseModel):


class EvalPiplineConfig(BaseModel):
"""Single evaluator configuration item"""
"""Single evaluator configuration item."""
name: str
config: Optional[EvaluatorRuleArgs | EvaluatorLLMArgs] = None

Expand Down
3 changes: 2 additions & 1 deletion dingo/exec/local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,9 @@ def evaluate_single_data(self, dingo_id: str, eval_fields: dict, eval_type: str,
Model.set_config_rule(model, e_c_i.config)
elif eval_type == 'llm':
model_cls = Model.llm_name_map.get(e_c_i.name)
model = model_cls() # 实例化类为对象，避免多线程配置覆盖
model = model_cls()
Model.set_config_llm(model, e_c_i.config)
Model.set_config_llm(model_cls, e_c_i.config)
else:
raise ValueError(f"Error eval_type: {eval_type}")

Expand Down
Loading