-
Notifications
You must be signed in to change notification settings - Fork 267
Cleanup Templates/Issue-Links #1211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR cleans up issue template links and template files across the repository by removing redundant URL parameters that are already handled by template files, fixing improperly formatted templates, and correcting label and assignee references. The changes streamline the issue creation process by consolidating configuration in template files rather than URL parameters.
Key changes:
- Removed URL parameters (assignees, labels, titles) from README.md issue links where corresponding template files handle these fields
- Fixed template file formatting (added missing YAML delimiters, corrected label assignments)
- Updated assignee references (e.g.,
guohuideng→guohuideng2024,phumai→kurtcattischmidt) - Corrected label references to match actual GitHub labels (e.g.,
CSSTooltipPseudo→TooltipPseudo,PWA Widgets→Widgets)
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Removed redundant URL parameters from issue links and updated label references to match actual GitHub labels |
| .github/ISSUE_TEMPLATE/resource-timing-initiator-info.md | Updated assignee from guohuideng to guohuideng2024 |
| .github/ISSUE_TEMPLATE/resource-timing-content-encoding.md | Added missing YAML delimiters and updated assignee to guohuideng2024 |
| .github/ISSUE_TEMPLATE/pwa-widgets.md | Added missing Widgets label |
| .github/ISSUE_TEMPLATE/performancenavigationtiming-protocol-launch-timing-information.md | Added PerformanceNavigationTimingProtocolLaunch label |
| .github/ISSUE_TEMPLATE/hapticsdevice-api.md | Added WebHaptics label |
| .github/ISSUE_TEMPLATE/gamepad-event-driven-input-api.md | Created new template file with proper structure, labels, and assignees |
| .github/ISSUE_TEMPLATE/document-subtitle.md | Added DocumentSubtitle label |
| .github/ISSUE_TEMPLATE/digital-goods.md | Updated label from Digital Goods to Digital Goods API |
| .github/ISSUE_TEMPLATE/declarative-shadow-dom-style-sharing.md | Updated assignee from phumai to kurtcattischmidt |
| .github/ISSUE_TEMPLATE/allow-use-to-reference-entire-files.md | Added missing YAML delimiters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Initial plan * Fix GitHub capitalization in README.md line 71 Co-authored-by: mhochk <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: mhochk <[email protected]>
| | [Performance Control of Embedded Content](https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/PerformanceControlOfEmbeddedContent/explainer.md) | <a href="https://github.com/MicrosoftEdge/MSEdgeExplainers/labels/Performance%20Control%20of%20Embedded%20Content"></a> | [New Issue...](https://github.com/MicrosoftEdge/MSEdgeExplainers/issues/new?template=performance-control-of-embedded-content.md) | Web Perf | | ||
| | [Animation Smoothness](AnimationSmoothness/explainer.md) | <a href="https://github.com/MicrosoftEdge/MSEdgeExplainers/labels/AnimationSmoothness"></a> | [New Issue...](https://github.com/MicrosoftEdge/MSEdgeExplainers/issues/new?assignees=jenna-sasson&labels=AnimationSmoothness&title=%5BAnimationSmoothness%5D+%3CTITLE+HERE%3E) | Web Perf | | ||
| | [Event Phases For Reliably Fast DOM Operations](https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/EventPhases/explainer.md) | <a href="https://github.com/MicrosoftEdge/MSEdgeExplainers/labels/EventPhases"></a> | [New Issue...](https://github.com/MicrosoftEdge/MSEdgeExplainers/issues/new?assignees=slightlyoff&labels=EventPhases&title=%5BEventPhases%5D+%3CTITLE+HERE%3E) | Web Perf | | ||
| | [Event Phases For Reliably Fast DOM Operations](https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/EventPhases/explainer.md) | <a href="https://github.com/MicrosoftEdge/MSEdgeExplainers/labels/Event%20Phases"></a> | [New Issue...](https://github.com/MicrosoftEdge/MSEdgeExplainers/issues/new?assignees=slightlyoff&labels=Event%20Phases&title=%5BEventPhases%5D+%3CTITLE+HERE%3E) | Web Perf | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These &title= URL's are very inconsistent - might make sense to standardize (or remove the existing ones) as a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I agree that standardized titles would look nice, I don't feel strongly enough about their value to force that change upon all the various feature teams that chose their titles already.
If you (or someone else) chooses to try to standardize them in the future, please be sure to also sweep across all the titles in the various template files - as the &titles are only there in the URLs for those without a template file to provide the title value.
Cleaning up (and sometimes fixing) various 'New Issue...' links and their associated templates.
This does not address: