-
Notifications
You must be signed in to change notification settings - Fork 266
Adds details on property inheritance #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
diekus
wants to merge
3
commits into
MicrosoftEdge:main
Choose a base branch
from
diekus:draggable-explainer-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -118,6 +118,10 @@ The (Generic Beautiful) button has the `app-region` set to `drag`. This button c | |
|
|
||
| > Note: This is just an example to test the _current_ behaviour on elements that have animations. The `app-region` is generally used on emulated titlebars or other UX designed to let the end user move the window around. | ||
|
|
||
| ### Inheritance | ||
|
|
||
| The property inherits and both `drag` and `no-drag` transfer to child elements. In either case, child elements can override it but setting the value of the property to an alternate value. | ||
|
|
||
| ### `app-region` and pointer events | ||
|
|
||
| Current implementations of `app-region` **consume all pointer events**, even if they don't result in a drag. Interactive elements inside an area defined with `app-region: drag` will require a `app-region: no-drag` to be interacted with. | ||
|
|
@@ -158,6 +162,11 @@ Note that there is [positive](https://github.com/w3c/csswg-drafts/issues/7017#is | |
| ## Accessibility, Privacy, and Security Considerations | ||
| There are no considerations at this time. | ||
|
|
||
| ## Open Questions | ||
| - The name `app-region` is not representative of the property's purpose. A new name would be in order to better represent the capability (`drag-area`?, `drag-point`?, `drag-behavior`?). See this [issue](https://github.com/w3c/csswg-drafts/issues/13102) to contribute to the discussion. | ||
|
|
||
| - There are cases where | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfinished sentence. |
||
|
|
||
| ## References & acknowledgements | ||
|
|
||
| This work aknowledges and thanks the following individuals for their contributions: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.