fix(ramp): unblock SPEI ramp with separate flag, i18n migration, dead code cleanup (#312)#313
Open
GBOYEE wants to merge 1 commit into
Open
fix(ramp): unblock SPEI ramp with separate flag, i18n migration, dead code cleanup (#312)#313GBOYEE wants to merge 1 commit into
GBOYEE wants to merge 1 commit into
Conversation
… code cleanup (Micopay#312) - Split VITE_ENABLE_DEFI_TRADING into two flags: showDefi (DEX/Blend) and showSpeiRamp (SPEI KYC + on/offramp), independently enableable - Migrated KYCScreen hardcoded strings to i18n (en/es) via react-i18next - Removed dead no-op CapApp block from KYCScreen - Marked registerBankAccount as @deprecated (backend route removed June 30) - Updated Explore.tsx to show CETES card when either flag is true Closes Micopay#312.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #312
Changes
Flag split — VITE_ENABLE_DEFI_TRADING now controls only DEX buy/sell + Blend (simulated). New VITE_ENABLE_SPEI_RAMP controls SPEI KYC + onramp + offramp (real funds). Both can be set independently.
i18n migration — KYCScreen.tsx no longer has hardcoded strings. All text moved to i18n/en.json and i18n/es.json under the kyc key, using useTranslation() like every other screen.
Dead code removed — The no-op
if (CapApp && (CapApp as any)) {}block deleted. The real CapApp.addListener('appStateChange') polling loop is preserved.registerBankAccount marked @deprecated — Backend route was removed June 30. CLABE is now captured inside the hosted Etherfuse KYC flow. Zero callers in the codebase.
Testing