Fix/balance change calculation gas sponsored #7608
Closed
+76
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
matthewwalsh0
requested changes
Jan 14, 2026
| return getSimulationBalanceChange( | ||
| previousBalance, | ||
| newBalance, | ||
| transactionResponse.gasCost, |
Member
There was a problem hiding this comment.
Do we not want to keep the gas cost in for non-sponsored here?
| getSimulationConfig, | ||
| transactions, | ||
| withGas: true, | ||
| withGas: !request.isGasFeeSponsored, |
Member
There was a problem hiding this comment.
We specify gas here to ensure a more accurate simulation that can't be as easily detected.
Why exactly would we not want that if sponsored if we mock the native balance below if insufficient?
| offset: BN = new BN(0), | ||
| ): SimulationBalanceChange | undefined { | ||
| const newBalanceBN = hexToBN(newBalance).add(new BN(offset)); | ||
| const newBalanceBN = hexToBN(newBalance).add(offset); |
Member
There was a problem hiding this comment.
The purpose of this offset is to remove any gas costs from the native balance change.
Do we know why this calculation isn't working if sponsored?
Is that the root of the issue rather than the withGas option?
Is the gasCost property still correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fixes a UX issue where, in fully sponsored transactions involving the native token, the displayed balance change incorrectly included gas fees that were not actually paid by the user.
References
For testing and validation, please refer to this hotfix PR, which includes the same changes applied as a patch:
MetaMask/metamask-extension#39219
Checklist
Note
Ensures native balance changes are accurate for gas‑sponsored transactions by excluding gas costs during simulation.
gasFeeTokensbefore simulation and determineisGasFeeSponsoredinTransactionControllerisGasFeeSponsoredtogetBalanceChangesand setsimulateTransactionswithGastofalsewhen sponsoredgetSimulationBalanceChangeto use state diffs directly (remove gas offset) and switchoffsettoBNisGasFeeSponsoredplumbed through and correct balance diffs; add expectations forwithGasbehaviorCHANGELOG.mdentry under UnreleasedWritten by Cursor Bugbot for commit d5234ea. This will update automatically on new commits. Configure here.