-
Notifications
You must be signed in to change notification settings - Fork 85
Impose max limit on in-cloud water-content in pc2_checks #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MichaelWhitall
wants to merge
21
commits into
MetOffice:main
Choose a base branch
from
MichaelWhitall:max_in_cloud_checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
bfa6623
Implemented new in-cloud water-content check in pc2_checks (and chang…
MichaelWhitall a30e93a
Add new kernel to do the safety-checks on prognostic precip fraction.
MichaelWhitall bb05154
Skip existing call to fracs_consistency on input to comorph if the ch…
MichaelWhitall 65d1402
Fixed misplaced comma.
MichaelWhitall 039c24c
Moved map_w3 to before map_wth in the argument list, to get same orde…
MichaelWhitall 1851bcc
Added l_pc2_checks_cfffix to the cloud namelist and now use to toggle…
MichaelWhitall 1c36de1
Moved the call to lsp_precfrac_checks outside of cld_alg, so that the…
MichaelWhitall 607a342
Switched the new functionality on in the comorph_dev rose-stem test.
MichaelWhitall 154a87b
Signed the contributors.md file.
MichaelWhitall f8e4bd0
Update KGOs for CoMorph rose-stem tests that change answers.
MichaelWhitall 625eefa
Lower-cased missed fortran keywords in comment.
MichaelWhitall ff3dcca
Lower-cased missed fortran keywords in comment.
MichaelWhitall f4f5149
Changed level-loops in pc2_checks and lsp_precfrac_checks kernels to …
MichaelWhitall e843639
Changed level-loops in pc2_checks and lsp_precfrac_checks kernels to …
MichaelWhitall 1872fcb
Changed declaration style of precfrac in semi_implicit_timestep to ma…
MichaelWhitall 6e29705
Changed declaration style of precfrac in semi_implicit_timestep to ma…
MichaelWhitall 071fe16
Make the precision changes on copying data in the lsp_precfrac_checks…
MichaelWhitall 6d8d84f
Make the precision changes on copying data in the lsp_precfrac_checks…
MichaelWhitall d998e33
Removed temp logical l_pc2_checks_cfffix; hard-code the bug-fix instead.
MichaelWhitall 45bb0c1
Removed temp logical l_pc2_checks_cfffix; hard-code the bug-fix instead.
MichaelWhitall b885c9a
Updated KGOs consistent with now hard-coding the pc2_checks CFF bug-fix.
MichaelWhitall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you are still leaving the original as-is in fracs_consistency? I guess the checks will in general be done elsewhere now- but is it worth comment in fracs_consistency just to mention that there is actually a better way of doing this now?