Skip to content

Add parallel adjoint tests#398

Open
DrTVockerodtMO wants to merge 6 commits intoMetOffice:mainfrom
DrTVockerodtMO:add_parallel_tests
Open

Add parallel adjoint tests#398
DrTVockerodtMO wants to merge 6 commits intoMetOffice:mainfrom
DrTVockerodtMO:add_parallel_tests

Conversation

@DrTVockerodtMO
Copy link
Copy Markdown
Contributor

@DrTVockerodtMO DrTVockerodtMO commented Mar 26, 2026

PR Summary

Sci/Tech Reviewer: Tom Hill (@tom-j-h)
Code Reviewer: Harry Shepherd (@harry-shepherd)

Adds parallel testing to the adjoint_tests application. Includes some small changes to the semi_implicit_solver step to avoid using PSyKAl-lite code.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - add_parallel_tests/run5

Suite Information

Item Value
Suite Name add_parallel_tests/run5
Suite User terence.vockerodt
Workflow Start 2026-04-03T10:59:55
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2026.03.2 True
jules MetOffice/jules@2026.03.2 True
lfric_apps DrTVockerodtMO/lfric_apps@add_parallel_tests False
lfric_core MetOffice/lfric_core@018e40c True
moci MetOffice/moci@2026.03.2 True
SimSys_Scripts MetOffice/SimSys_Scripts@4387949 True
socrates MetOffice/socrates@2026.03.2 True
socrates-spectral MetOffice/socrates-spectral@2026.03.2 True
ukca MetOffice/ukca@2026.03.2 True

Task Information

✅ succeeded tasks - 1171

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@DrTVockerodtMO DrTVockerodtMO self-assigned this Mar 26, 2026
Copy link
Copy Markdown
Contributor

@tom-j-h Tom Hill (tom-j-h) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change.

@DrTVockerodtMO
Copy link
Copy Markdown
Contributor Author

I am going to add a test that combines the MPI partitioning with OpenMP. Instead of re-running the entire suite I will just run the adjoint_tests group for that and include an additional trac.log.

@DrTVockerodtMO
Copy link
Copy Markdown
Contributor Author

I am going to add a test that combines the MPI partitioning with OpenMP. Instead of re-running the entire suite I will just run the adjoint_tests group for that and include an additional trac.log.

I have now re-run and attached a full developer suite, all green!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjoint tests not tested in parallel

3 participants