Refactor run_command error handling #164
Merged
+68
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
james-bruten-mo
left a comment
james-bruten-mo
left a comment
There was a problem hiding this comment.
Mostly fine, just one modification if that's ok
| """ | ||
|
|
||
| import os | ||
| from datetime import datetime |
Collaborator
There was a problem hiding this comment.
Thinking about this, can we keep the printing of the timestamp in please. I appreciate it'll need adding to 3 print statements now, but the number of times I've debugged partially using that timestamp means I think it's worth it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
Refactor
run_command()and add loggingDependency
None
Checklist