Repository navigation
perf(api): only send Content-Type: application/json when there's a body - #765
Closed
yggdrasilworld wants to merge 1 commit into
Closed
yggdrasilworld wants to merge 1 commit into
yggdrasilworld wants to merge 1 commit into
Conversation
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
yggdrasilworld
force-pushed
the
fix/get-content-type-cors-686
branch
from
October 16, 2026 12:34
e93ee40 to
38156be
Compare
A GET carrying Content-Type: application/json isn't a CORS 'simple request' — it triggers a preflight on every read, doubling fetch latency. Declare it only when a body is actually sent. Resolves MergeFi#686
Author
|
Rebased onto current main — the equivalent change has already landed upstream (post-rebase diff vs main is empty), so this PR is superseded. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A GET carrying
Content-Type: application/jsonisn't a CORS 'simple request' — it triggered a preflight on every read, doubling fetch latency.Fix
Only declare it when a body is actually sent.
Resolves #686
Payment: Base USDC
0xD40Df5c27cEa7dd78A3c345401995c319589334e