Repository navigation
fix(wallet): guard the three unguarded localStorage accesses - #759
Closed
yggdrasilworld wants to merge 1 commit into
Closed
yggdrasilworld wants to merge 1 commit into
yggdrasilworld wants to merge 1 commit into
Conversation
WalletContext called getItem/removeItem/setItem unguarded — where storage access throws (Safari private mode, blocked site data), the mount effect threw, never cleared, and wallet actions stayed disabled. Wrapped in the same best-effort try/catch auth.ts uses — the in-memory state still works even when storage can't be written. Resolves MergeFi#705
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
WalletContextcalledlocalStorage.getItem/removeItem/setItemunguarded — where storage access throws (Safari private mode, blocked site data), the mount effect threw andinitializingnever cleared, leaving wallet actions disabled.Fix
Wrapped all three in the same best-effort try/catch
auth.tsuses — in-memory state still works when storage can't be written.Resolves #705 · Related: #190
Payment: Base USDC
0xD40Df5c27cEa7dd78A3c345401995c319589334e