Repository navigation
fix(a11y): only set aria-controls on the active tab - #752
Closed
yggdrasilworld wants to merge 1 commit into
Closed
yggdrasilworld wants to merge 1 commit into
yggdrasilworld wants to merge 1 commit into
Conversation
Only the active tab's panel renders, so inactive tabs' aria-controls pointed at tabpanel ids not in the DOM — an ARIA reference error. Omit aria-controls on inactive tabs. Resolves MergeFi#710
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Rebased onto current main — the equivalent change has already landed upstream (post-rebase diff vs main is empty), so this PR is superseded. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every tab set
aria-controls=tabpanel-{key}, but only the active panel renders — inactive tabs pointed at missing tabpanel ids (an ARIA reference error axe flags).Fix
aria-controlsonly on the active tab.Resolves #710
Payment: Base USDC
0xD40Df5c27cEa7dd78A3c345401995c319589334e