Repository navigation
Conversation
Fixes MergeFi#75. MilestonesPage was computing funding progress as distributed / budget without guarding against budget === 0, producing NaN or Infinity that silently collapsed the progress bar or displayed a misleading '0%'. Additionally, the text readout (formatPercent) was unclamped while the bar was clamped to 100%, causing visual disagreement for over-funded milestones. Replaced the unsafe division with a hasBudget guard. When budget is 0, the UI now explicitly renders 'Not yet funded'. When distributed exceeds budget, the bar turns amber and the text readout honestly reports the over-distributed percentage instead of capping it invisibly.
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75.
MilestonesPage was computing funding progress as distributed / budget without guarding against budget === 0, producing NaN or Infinity that silently collapsed the progress bar or displayed a misleading '0%'. Additionally, the text readout (formatPercent) was unclamped while the bar was clamped to 100%, causing visual disagreement for over-funded milestones.
Replaced the unsafe division with a hasBudget guard. When budget is 0, the UI now explicitly renders 'Not yet funded'. When distributed exceeds budget, the bar turns amber and the text readout honestly reports the over-distributed percentage instead of capping it invisibly.