Repository navigation
Conversation
Fixes MergeFi#91. adaptReputation was computing completionRate and onTimeDeliveryRate by dividing a coerced decimal by 100 without any upper/lower bound clamping. If the backend sent a corrupted value like '150', it would flow through as 1.5 and render as '150%' on the public reputation page. Replaced the inline division with a call to the previously unused coerceFraction helper (wrapping the division result) to guarantee the output is strictly bounded between 0 and 1. Added regression tests in src/lib/adapters.test.ts covering: - Out-of-range values (>100%) clamping to exactly 1 - Negative values clamping to exactly 0 - Normal in-range values preserving without regression - Null snapshot fallback to 0
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #91.
adaptReputation was computing completionRate and onTimeDeliveryRate by dividing a coerced decimal by 100 without any upper/lower bound clamping. If the backend sent a corrupted value like '150', it would flow through as 1.5 and render as '150%' on the public reputation page.
Replaced the inline division with a call to the previously unused coerceFraction helper (wrapping the division result) to guarantee the output is strictly bounded between 0 and 1.
Added regression tests in src/lib/adapters.test.ts covering: